RFR: 1536: The method "JiraIssue#setState" is invalid when using the argument "State.CLOSED" [v2]

Magnus Ihse Bursie ihse at openjdk.org
Wed Aug 10 15:18:01 UTC 2022


On Wed, 10 Aug 2022 15:14:24 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently, when the method "JiraIssue#setState" is invoked with the argument "State.CLOSED", it can't work as expected. This patch fixes it and add a manual test case for it. And I run the newly added test munually to close SKARA-1463 [1] and SKARA-1516 [2] so that this patch can be verified.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>> 
>> [1] https://bugs.openjdk.org/browse/SKARA-1463
>> [2] https://bugs.openjdk.org/browse/SKARA-1516
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test case.

Looks good to me. That's the problem with too deep nesting levels, bugs like this creep in.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1353


More information about the skara-dev mailing list