RFR: 1537: SponsorCommand can fail indefinitely with '/integrate auto'
erikj at openjdk.org
Wed Aug 10 21:34:35 UTC 2022
On Wed, 10 Aug 2022 21:21:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> This patch fixes two issues. The main one is an Optional "No value present" issue in SponsorCommand which can happen in combination with '/integrate auto' if a sponsor is too quick. With this patch, appropriate error replies are added by the bot when this happens, asking the sponsor to try again when the PR is in a suitable state. The commands on PRs and commits are designed to be evaluated in order, so there is really no way around this if they aren't issued in the right order.
> Related to this, I'm also fixing SKARA-1534, where CheckWorkItem would continuously post new '/integrate' comments when '/integrate auto' is activated. This would typically happen in conjunction with the above sponsor problem, and did actually cause my new test to fail (as it found 2 replies to /integrate instead of 1), so I decided to fix that in the same patch. To do that, I exposed some static utility methods from PullRequestCommandWorkItem to be able to identify if any unhandled '/integrate' commands were already present in the PR.
The previous behavior for the SponsorCommand lead to eternal retries in processing the /sponsor command, while CheckWorkItem would continue to post '/integrate' over and over again, so it's pretty serious to get this fixed. We currently have two PRs suffering from this live.
More information about the skara-dev