RFR: 1542: Census Namespace missing hashCode and equals [v2]

Erik Joelsson erikj at openjdk.org
Thu Aug 11 21:42:22 UTC 2022


On Thu, 11 Aug 2022 21:22:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> This looks fine presuming that name, mapping, and reverse are always non-null.

Right, I checked the code again, and while the two maps will currently never be null, the name field could potentially end up as null if given bad input data. I think it's good to be defensive and just use the static Object.equals for all the fields. I did this by just rerunning the intellij wizard.

-------------

PR: https://git.openjdk.org/skara/pull/1356


More information about the skara-dev mailing list