RFR: 1355: Mirror bot needs branch selection based on patterns

Kevin Rushforth kcr at openjdk.org
Tue Aug 16 20:17:44 UTC 2022


On Mon, 15 Aug 2022 20:14:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch makes it possible to configure mirrored branches with regex patterns. For what I think is improved readability, I made it possible to supply the patterns as an array of strings, so we can have multiple separate patterns. It's still possible to define "branches" as a comma separated list, for backwards compatibility.
> 
> When deploying this change, I will need to delete the existing local repos used for mirroring on the bot runner machine, because the method by which repos are cloned is changing (for repos that do not just mirror "everything"). Going forward, I think it's good to always clone all repos the same way, regardless of configuration.
> 
> There is another behavioral change, where I'm adding `--force` when pushing branches with `includeTags`. It happens a bit too often that a repo maintainer changes tags, which currently causes error for any mirroring job because we aren't force pushing tags. I don't think we ever want to not force update when mirroring repos.

Marked as reviewed by kcr (Reviewer).

-------------

PR: https://git.openjdk.org/skara/pull/1358


More information about the skara-dev mailing list