Integrated: 1431: The method TestPullRequest#diff sometimes returns wrong information

[Guoxiong Li]

On Sat, 20 Aug 2022 07:53:23 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> The method `TestPullRequest#diff` always passes the head hash of the target branch to the method `Repository#diff` as the base hash. But it may be wrong when the target branch was submitted some new commits after creating the pull request. `TestPullRequest#diff` should find the last common hash of the source and target branch as the base hash.
> 
> This patch fixes the bug and adds the test case. I don't know whether it is good to place the test case at the class `CSRBotTests`, but the method `CSRBotTests#testBackportCsr` indeed contains the situation of this bug.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: cd765e93
Author:    Guoxiong Li <gli at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/cd765e9302076b87c31d744b833c97c0cd2b80da
Stats:     18 lines in 2 files changed: 10 ins; 3 del; 5 mod

1431: The method TestPullRequest#diff sometimes returns wrong information

Reviewed-by: ihse, erikj

-------------

PR: https://git.openjdk.org/skara/pull/1360