RFR: 1560: Backport command fails to load census [v2]

Erik Joelsson erikj at openjdk.org
Wed Aug 24 21:48:38 UTC 2022


> This patch attempts to fix the problem where a commit command (in our case a /backport command) fails to instantiate a CensusInstance, due to the configured jcheck "project", at the particular commit, not existing in the census in question. What happens then is that CensusInstance.create fails, which triggers an endless series of retries in the bot.
> 
> Since none of the current commit commands have a need for the "project" part of the census, I decided to create a separate CensusInstance type `LimitedCensusInstance` without the "project", and explicitly use this in the commit commands.
> 
> Tests are passing, and I could manually verify that this solves the problem we currently have with a bad /backport command in a private GitLab instance.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Added comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1362/files
  - new: https://git.openjdk.org/skara/pull/1362/files/250f6f9f..1f4f2583

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1362&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1362&range=00-01

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/skara/pull/1362.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1362/head:pull/1362

PR: https://git.openjdk.org/skara/pull/1362


More information about the skara-dev mailing list