RFR: 1555: Remove support for review by award emojis in GitLab

Magnus Ihse Bursie ihse at openjdk.org
Tue Aug 30 10:26:48 UTC 2022

On Thu, 25 Aug 2022 18:45:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch removes support for using award emojis for marking an MR in GitLab as reviewed. This was the original Skara implementation from back when GitLab did not have an `approve` button. In https://github.com/openjdk/skara/pull/939, support for the new approve button was introduced and the award emojis were deprecated. I think it's now time to remove them completely.
> The removed test had an assumeTrue that made it never run, as the TestForge had support for review body, so I chose to remove the whole test.

Good riddance!


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1363

More information about the skara-dev mailing list