RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v7]
Erik Joelsson
erikj at openjdk.org
Thu Dec 1 17:11:13 UTC 2022
On Thu, 1 Dec 2022 16:55:56 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> Currently, the command `git skara jcheck` can only use the `.jcheck/conf` configuration file in the current checking commit.
>> However, sometimes users want to run jcheck with different configurations to validate their commits. Therefore, we need to upgrade `git skara jcheck`.
>>
>> In this patch, `git skara jcheck` would be able to support following usecases.
>>
>> 1. Run jcheck on a commit or a series of commits using the .jcheck/conf in the same commit. (what we do by default today)
>> `git skara jcheck`
>>
>> 2. Run jcheck on a commit or a series of commits using the .jcheck/conf in a different specified commit.
>> `git skara jcheck --specified-conf-commit <COMMIT HASH>`
>>
>> 3. Run jcheck on a commit or a series of commits using the .jcheck/conf in my workspace.
>> `git skara jcheck --workspace-conf`
>>
>> 4. Run jcheck on a commit or a series of commits using a config file that I point to directly, that may have any name.
>> `git skara jcheck --workspace-conf --conf-file <FILENAME>`
>>
>> 5. Run jcheck on the diff in my current workspace, either --staged or not using the .jcheck/conf in my workspace.
>> `git skara jcheck --workspace-diff`
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> delete wholeHash() and update copyright headers
Marked as reviewed by erikj (Lead).
-------------
PR: https://git.openjdk.org/skara/pull/1428
More information about the skara-dev
mailing list