RFR: 1713: Fix gradle deprecations

Mon Dec 5 21:04:53 UTC 2022

On Mon, 5 Dec 2022 19:34:07 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch tries to fix the deprecation warnings currently printed by Gradle when building Skara.
> 
> * enabled -> required: a simple rename of an attribute
> * TestReport was a little trickier, but as far as I can tell, this is how it's supposed to be done now, and it works just as well/bad as it did before this change. It's not clear to me what the testReport task is good for here, as it seems to me that it will only run if all tests are successful.
> * ModulePlugin.java: Was using some deprecated APIs. While at it I let Intellij fix some things that it was warning about. The null checks I removed were weird as the returned object was essentially an `Optional` (a different implementation of the same thing). Switched to using the modern instanceof assignment.
> * I updated gradle-wrapper.properties to match the version used by the Skara gradlew wrapper script. Intellij will by default pick the version from the properties file, so as long as we have that file around, we should make sure they match. I needed to do this to make the build succeed in Intellij as some of these changes didn't work in Gradle 7.2.

LGTM. Thanks for doing the house cleaning stuff.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1433