RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v5]

[Zhao Song]

On Tue, 6 Dec 2022 18:25:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename variables
>
> bots/common/src/main/java/org/openjdk/skara/bots/common/BotUtils.java line 46:
> 
>> 44:         String confFile;
>> 45:         confFile = pr.repository().fileContents(".jcheck/conf", pr.headHash().hex())
>> 46:                 .orElse(pr.repository().fileContents(".jcheck/conf", pr.targetRef()).orElseThrow());
> 
> Could you add a message to the exception in orElseThrow describing what's happening. Something like
> 
> () -> new RuntimeException("Missing .jcheck/conf in both src and target of PR " + pr)
> 
> 
> Also, no need to split declaration of confFile to a separate line anymore, nor declare the type.

Sure, will fix it

-------------

PR: https://git.openjdk.org/skara/pull/1435