RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v5]

Zhao Song zsong at openjdk.org
Tue Dec 6 19:48:45 UTC 2022

On Tue, 6 Dec 2022 19:34:40 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java line 276:
>>> 274:             }
>>> 275:             throw e;
>>> 276:         }
>> Instead of catching this exception, please use the onError method on the request to register an error handler.
> Sorry, I couldn't find a good way to use errorHandler with the current `RestRequest#transformBadResponse`.
> We will not be able to return `Optional.empty()` when the error is 404 Not Found.

Ah, see your comments below. I know how to do it now. Thank you


PR: https://git.openjdk.org/skara/pull/1435

More information about the skara-dev mailing list