RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v5]

Zhao Song zsong at openjdk.org
Tue Dec 6 20:30:53 UTC 2022


On Tue, 6 Dec 2022 18:36:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename variables
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LimitedCensusInstance.java line 77:
> 
>> 75:             conf = Optional.of(Arrays.stream(contents.get().split("\n")).toList());
>> 76:         }
>> 77:         return conf.map(JCheckConfiguration::parse);
> 
> This seems a bit awkward. I think something like this should do it (untested and likely not completely right):
> 
> return remoteRepo.fileContents(name, ref).map(contents -> JCheckConfiguration.parse(Arrays.stream(contents.split("\n")).toList()));

I think it's right

-------------

PR: https://git.openjdk.org/skara/pull/1435


More information about the skara-dev mailing list