RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v7]
Erik Joelsson
erikj at openjdk.org
Tue Dec 6 23:42:39 UTC 2022
On Tue, 6 Dec 2022 21:53:32 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> In [SKARA-1393](https://bugs.openjdk.org/browse/SKARA-1393), I added some checks to ensure the target branch of a pr contains valid jcheck configuration. This change went live on November 28, however, some users found that the warning of "No .jcheck/conf found" printed after they integrated their pr. After more investigation, I am thinking it's maybe a GitLab bug. Since when the issue happens, GitLab will always return "Commit Not Found", so we could have a temporary workaround right now.
>>
>> For GitLab REST API:
>> If commit not found, it will return "404 Commit Not Found"
>>
>> If file not found it will return "404 File Not Found"
>>
>> For Github REST API:
>> If commit not found, it will return "No commit found for the ref "
>>
>> If file not found it will return "Not Found"
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> fix problems
Marked as reviewed by erikj (Lead).
-------------
PR: https://git.openjdk.org/skara/pull/1435
More information about the skara-dev
mailing list