RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed

Zhao Song zsong at openjdk.org
Wed Dec 7 22:41:01 UTC 2022

On Wed, 7 Dec 2022 21:38:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> When a pr is created, pr bot will run jcheck to check whether this commit is good. However, currently, we only run jcheck with the configuration from the target branch. Sometimes, user wants to modify jcheck configuration and accidentally messes up the format. In this case, pr bot would not be able to find this problem. After this commit with badly formatted jcheck configuration integrated, all the jcheck will fail and our bot gets stuck into a retry loop.
>> In this patch, if jcheck configuration file is updated, the bot will run jcheck twice, once with the configuration in the target and once with the new one in the source. So if the new configuration has any problem, it will became an integration blocker.
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java line 2786:
>> 2784:             try (var output = new FileWriter(checkConf.toFile(), true)) {
>> 2785:                 output.append("\nRandomCharacters");
>> 2786:             }
> This could be done with
> Files.writeString(checkConf, "text...", StandardOpenOption.APPEND)

It's better! Thx


PR: https://git.openjdk.org/skara/pull/1439

More information about the skara-dev mailing list