RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v2]

Zhao Song zsong at openjdk.org
Wed Dec 7 23:33:05 UTC 2022

On Wed, 7 Dec 2022 23:29:31 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> When a pr is created, pr bot will run jcheck to check whether this commit is good. However, currently, we only run jcheck with the configuration from the target branch. Sometimes, user wants to modify jcheck configuration and accidentally messes up the format. In this case, pr bot would not be able to find this problem. After this commit with badly formatted jcheck configuration integrated, all the jcheck will fail and our bot gets stuck into a retry loop.
>> In this patch, if jcheck configuration file is updated, the bot will run jcheck twice, once with the configuration in the target and once with the new one in the source. So if the new configuration has any problem, it will became an integration blocker.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix some problems

vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1731:

> 1729:                         .anyMatch(diff -> diff.patches().stream()
> 1730:                                 .anyMatch(patch -> patch.toString().contains(filename))));
> 1731:     }

@erikj79 I am not sure I get you correctly. Correct me if I misunderstand what you mean.


PR: https://git.openjdk.org/skara/pull/1439

More information about the skara-dev mailing list