RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v5]

Zhao Song zsong at openjdk.org
Thu Dec 8 21:00:40 UTC 2022


> When a pr is created, pr bot will run jcheck to check whether this commit is good. However, currently, we only run jcheck with the configuration from the target branch. Sometimes, user wants to modify jcheck configuration and accidentally messes up the format. In this case, pr bot would not be able to find this problem. After this commit with badly formatted jcheck configuration integrated, all the jcheck will fail and our bot gets stuck into a retry loop.
> 
> In this patch, if jcheck configuration file is updated, the bot will run jcheck twice, once with the configuration in the target and once with the new one in the source. So if the new configuration has any problem, it will became an integration blocker.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  fix problems

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1439/files
  - new: https://git.openjdk.org/skara/pull/1439/files/4737447d..dfe06f6c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1439&range=04
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1439&range=03-04

  Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1439.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1439/head:pull/1439

PR: https://git.openjdk.org/skara/pull/1439


More information about the skara-dev mailing list