RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v3]
Zhao Song
zsong at openjdk.org
Thu Dec 8 21:00:41 UTC 2022
On Thu, 8 Dec 2022 19:36:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix problems
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequestUtils.java line 168:
>
>> 166: var localRepo = hostedRepositoryPool.checkout(pr.repository(), pr.headHash().hex(), path);
>> 167: localRepo.fetch(pr.repository().url(), "+" + pr.targetRef() + ":prutils_targetref", false);
>> 168: localRepo.fetch(pr.repository().url(), "+" + pr.sourceRef() + ":prutils_sourceref", false);
>
> I'm curious as to why this is needed. Line 166 should make sure we are fetching the source/head of the pr. I don't see any use of the local branch `prutils_sourceref`.
Sorry, I forget to delete it. I was thinking we need this and then I found it is useless, so I didn't use it any more. But I forget to delete it later.
-------------
PR: https://git.openjdk.org/skara/pull/1439
More information about the skara-dev
mailing list