Integrated: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed

Zhao Song zsong at
Thu Dec 8 22:15:46 UTC 2022

On Wed, 7 Dec 2022 19:44:52 GMT, Zhao Song <zsong at> wrote:

> When a pr is created, pr bot will run jcheck to check whether this commit is good. However, currently, we only run jcheck with the configuration from the target branch. Sometimes, user wants to modify jcheck configuration and accidentally messes up the format. In this case, pr bot would not be able to find this problem. After this commit with badly formatted jcheck configuration integrated, all the jcheck will fail and our bot gets stuck into a retry loop.
> In this patch, if jcheck configuration file is updated, the bot will run jcheck twice, once with the configuration in the target and once with the new one in the source. So if the new configuration has any problem, it will became an integration blocker.

This pull request has now been integrated.

Changeset: 69da5904
Author:    Zhao Song <zsong at>
Stats:     181 lines in 4 files changed: 161 ins; 8 del; 12 mod

1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed

Reviewed-by: erikj



More information about the skara-dev mailing list