RFR: 1722: Add duration logging for RestRequestCache lock

Magnus Ihse Bursie ihse at openjdk.org
Wed Dec 14 16:38:45 UTC 2022


On Wed, 14 Dec 2022 16:35:12 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This patch adds additional logging of durations for things that take time. In this case it's measuring how long it takes to get the lock before calling a remote REST API.
>
> network/src/main/java/org/openjdk/skara/network/RestRequestCache.java line 228:
> 
>> 226:             log.finer("Not using response cache for " + finalRequest + " (" + authId + ")");
>> 227:             Instant lastUpdate;
>> 228:             var beforeLock = Instant.now();
> 
> Should this not be accompanied with any logging?

Ah, I see, you measure the time across two locks. Nevermind.

-------------

PR: https://git.openjdk.org/skara/pull/1444


More information about the skara-dev mailing list