RFR: 1714: CSR detection only happens on the title bug of a PR

Zhao Song zsong at openjdk.org
Thu Dec 15 18:40:45 UTC 2022

On Thu, 15 Dec 2022 17:33:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Currently, our bots only detect CSR issues that are directly linked to the main issue. 
>> With this patch, our bots will be able to detect CSR issues that are linked to all of the issues that this PR solves. Additionally, all detected CSR issues will affect the integration blockers.
>> The `/csr needed` command will allow you to create a CSR issue that is linked to any of the issues solved by this PR. The `/csr unneeded` command will be blocked if any of the issues associated with this PR have an active CSR issue.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java line 217:
>> 215:                 pr.addLabel(CSR_LABEL);
>> 216:             }
>> 217:             return;
> I'm not sure about this behavior. We loop until we find an existing CSR, then print a reply based on the state of that CSR.

Yes, I think this behavior is right because if we could reach the return statement, it means we already found a non-withdrawn CSR.


PR: https://git.openjdk.org/skara/pull/1443

More information about the skara-dev mailing list