Integrated: 1728: Should iterate over all issues in PullRequestWorkItem in CSR bot
Zhao Song
zsong at openjdk.org
Thu Dec 22 21:17:12 UTC 2022
On Thu, 22 Dec 2022 19:04:34 GMT, Zhao Song <zsong at openjdk.org> wrote:
> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714) on the staging environment, I discovered a bug in the PullRequestWorkItem in the CSR bot. The issue is that the for loop does not always iterate over all CSR issues for a pull request.
>
> For example, if we have two active CSR issues (csr1 and csr2) for one pull request, and we withdraw csr2, the loop will exit early after iterating over csr1 and CSR_UPDATE_MARKER will not be added, which means the PR body will not be updated and the status change of csr2 will not be displayed.
>
> Also, if we find a withdrawn pr, we need to add CSR_UPDATE_MARKER to the pr body.
This pull request has now been integrated.
Changeset: e66ba112
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/e66ba11213957b2235e623d94de3137cef8824cc
Stats: 35 lines in 2 files changed: 5 ins; 8 del; 22 mod
1728: Should iterate over all issues in PullRequestWorkItem in CSR bot
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1449
More information about the skara-dev
mailing list