RFR: SKARA-1333: Sponsor label only removed if PR is actually sponsored [v2]

[Guoxiong Li]

On Tue, 8 Feb 2022 14:34:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments.
>
> Looks good, just some language nits in comments.

@erikj79 Thanks for the suggestion. I fixed the comments.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java line 139:
> 
>> 137:     }
>> 138: 
>> 139:     // This method only has one statement now, but it is kept intentionally to meet the change in the future.
> 
> I don't think we need a comment for this. To me it still makes sense to keep this method.

Fixed.

> bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java line 1471:
> 
>> 1469:             assertEquals(0, notPushed);
>> 1470: 
>> 1471:             // Mark the PR author as committer
> 
> Suggestion:
> 
>             // Mark the PR author a committer

Fixed.

> bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java line 1477:
> 
>> 1475:             var committerBot = PullRequestBot.newBuilder().repo(botUser).censusRepo(committerCensusBuilder.build()).build();
>> 1476: 
>> 1477:             // Issue an integrate command with being a Committer
> 
> Suggestion:
> 
>             // Issue an integrate command while being a Committer

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1282