RFR: SKARA-1347: Enable binary check
Erik Joelsson
erikj at openjdk.java.net
Wed Feb 9 15:30:48 UTC 2022
On Wed, 9 Feb 2022 15:19:59 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 266:
>>
>>> 264: @Override
>>> 265: public void visit(BinaryIssue issue) {
>>> 266: addFailureMessage(issue.check(), "The binary file " + issue.path().toString() + " is not allowed in this repository.");
>>
>> Can you make the message match the ones for executable files and symbolic links above?
>
> What about `String.format("Binary files are not allowed (file: %s)", issue.path())`?
Looks good.
-------------
PR: https://git.openjdk.java.net/skara/pull/1283
More information about the skara-dev
mailing list