Integrated: 1350: Altfixversions isn't checking Backport resolution
Erik Joelsson
erikj at openjdk.java.net
Wed Feb 16 15:27:56 UTC 2022
On Tue, 15 Feb 2022 18:39:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> This patch fixes a flaw in the altfixversion feature. Currently a backport with an altfixversion is considered valid if the state is "resolved". There are two problems with this. It misses backports that are in state closed. It could also cause false positives by accepting backports that aren't set to resolution "Fixed".
>
> To fix this, I've introduced a new method on the Issue interface "isFixed()". The default implementation (which will get used in testing) just delegates to isResolved(). For JiraIssue, it checks both the state and the resolution.
This pull request has now been integrated.
Changeset: 9ec7de68
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/9ec7de689d747c894d3c762e0c31f77dd69b44ae
Stats: 28 lines in 3 files changed: 24 ins; 0 del; 4 mod
1350: Altfixversions isn't checking Backport resolution
Reviewed-by: kcr
-------------
PR: https://git.openjdk.java.net/skara/pull/1286
More information about the skara-dev
mailing list