RFR: 1352: Configure GithubHost as offline

Magnus Ihse Bursie ihse at openjdk.java.net
Thu Feb 17 13:25:19 UTC 2022

On Wed, 16 Feb 2022 21:16:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> As a followup to [SKARA-1344](https://bugs.openjdk.java.net/browse/SKARA-1344), to better support the notifier to act through a mirror, we need another configuration option. When configuring a forge for the "originalrepository" option, we need to make it possible to not need to make any remote calls to that forge.
> Currently, when Skara creates a HostedRepository from a forge, it will always make a call to validate and initiate things. At least for GithubRepositories, this call isn't strictly necessary (and one could argue that it should be possible to get around this for Gitlab as well). Most callers for Forge::repository do expect this validation however, so we do not want to change the default behavior.
> I propose adding a new configure parameter to github forge, "offline", which defaults to false. If set to true, then it indicates that this forge is expected to be offline and the caller is not expected to try to perform any remote operations. This concept could certainly be expanded, but for now, the only thing we explicitly need to prevent is that validation/initialization when creating a repository. I would rather not spend more time implementing a more complete feature that is unlikely to be used.

LGTM, barring the null casting part. :)

forge/src/main/java/org/openjdk/skara/forge/Forge.java line 62:

> 60: 
> 61:     static Forge from(String name, URI uri) {
> 62:         return from(name, uri, (Credential) null);

Not entirely sure I like this. Maybe "from" has been overloaded too much?


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1287

More information about the skara-dev mailing list