Integrated: 1356: Notifer option to only interact with PRs

Erik Joelsson erikj at openjdk.java.net
Thu Feb 17 21:42:29 UTC 2022


On Thu, 17 Feb 2022 21:17:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The "pronly" option was introduced in [SKARA-445](https://bugs.openjdk.java.net/browse/SKARA-445) with the intention of support running just a PR based IssueNotifier, which includes resolving issues when a PR is integrated.
> 
> We need to run an IssueNotifier without it trying to resolve issues and without reacting to repo events. To support this, I've introduced a new config parameter on IssueNotifier: "resolve". Since we only need this when pronly is true, I didn't bother implementing support for that case and instead added a validation check in the factory so we don't accidentally try to run with an unsupported configuration.

This pull request has now been integrated.

Changeset: ba76661c
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/ba76661c850ba8e0d4c5e87fbfcee560c4ea93bb
Stats:     29 lines in 3 files changed: 26 ins; 0 del; 3 mod

1356: Notifer option to only interact with PRs

Reviewed-by: ihse, kcr

-------------

PR: https://git.openjdk.java.net/skara/pull/1288


More information about the skara-dev mailing list