RFR: 1298: IssueNotifier removes and re-adds review links and comments

Erik Joelsson erikj at openjdk.java.net
Mon Jan 3 14:42:49 UTC 2022


On Sun, 26 Dec 2021 11:21:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> When the author of the PR modified the PR body, the Github will store the PR body by using its internal line separator instead of `\n`. The method `parseIssues` can't identify the line separator so that it can't find any issue.
> 
> This patch enhances the pattern to let it identify the `\r` as well and the corresponding test case is added.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Nice find!

-------------

Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.java.net/skara/pull/1269


More information about the skara-dev mailing list