RFR: Refactoring in preparation for SKARA-1146 [v2]

Erik Joelsson erikj at openjdk.java.net
Thu Jan 6 22:14:54 UTC 2022

On Thu, 6 Jan 2022 21:58:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/JbsBackport.java line 55:
>>> 53:         var finalProperties = new HashMap<>(primary.properties());
>>> 54:         finalProperties.put("issuetype", JSON.of("Backport"));
>>> 55:         finalProperties.remove(RESOLVED_IN_BUILD);
>> Minor: did you mean to make this change in this PR? It doesn't seem behavior neutral (might be related to the follow-on PR?)
> You are right, this was part of my initial solution for the follow-on PR and I had forgotten about doing it.

Removed from this change and applied in the follow-on.


PR: https://git.openjdk.java.net/skara/pull/1270

More information about the skara-dev mailing list