RFR: 1146: IssueNotifier updates wrong backport records on new build tags [v2]
erikj at openjdk.java.net
Thu Jan 6 22:21:34 UTC 2022
On Thu, 6 Jan 2022 22:15:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> The IssueNotifier currently updates the Resolved in Build field for any and all backports regardless of if the fixVersion of the backport matches the tag or not. This patch fixes that. I didn't need to implement new tests, just adjusting the existing ones seems to be enough to verify the functionality, as one of the existing ones actually was verifying the faulty behavior already.
> Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> - Applying fix for the fallback backport creation mechanism
> - Merge branch 'SKARA-1146-refactor' into SKARA-1146-fixed-in-build
> - Require branch fixVersion and backport fixVersion to match to update resolved in build
Adding another potential fix for the issue. Skara has two implementations for creating backports in the first place. The main one is to call the backport extension API we have in JBS, which handles it correctly. There is also a fallback mechanism in Skara. The fallback mechanism, if used, would copy the Resolved in Build field from the main bug. This change makes sure that field is cleared.
In reality, I don't think the fallback mechanism is used anywhere other than in the tests themselves.
More information about the skara-dev