RFR: 1146: IssueNotifier updates wrong backport records on new build tags [v2]

openjdk-notifier[bot] duke at openjdk.java.net
Thu Jan 6 23:03:59 UTC 2022

On Thu, 6 Jan 2022 22:15:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The IssueNotifier currently updates the Resolved in Build field for any and all backports regardless of if the fixVersion of the backport matches the tag or not. This patch fixes that. I didn't need to implement new tests, just adjusting the existing ones seems to be enough to verify the functionality, as one of the existing ones actually was verifying the faulty behavior already.
> Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>  - Applying fix for the fallback backport creation mechanism
>  - Merge branch 'SKARA-1146-refactor' into SKARA-1146-fixed-in-build
>  - Require branch fixVersion and backport fixVersion to match to update resolved in build

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout SKARA-1146-refactor
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push


PR: https://git.openjdk.java.net/skara/pull/1271

More information about the skara-dev mailing list