RFR: 1146: IssueNotifier updates wrong backport records on new build tags [v3]
Kevin Rushforth
kcr at openjdk.java.net
Fri Jan 7 11:33:22 UTC 2022
On Thu, 6 Jan 2022 23:15:21 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> The IssueNotifier currently updates the Resolved in Build field for any and all backports regardless of if the fixVersion of the backport matches the tag or not. This patch fixes that. I didn't need to implement new tests, just adjusting the existing ones seems to be enough to verify the functionality, as one of the existing ones actually was verifying the faulty behavior already.
>
> Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' into SKARA-1146-fixed-in-build
> - Applying fix for the fallback backport creation mechanism
> - Merge branch 'SKARA-1146-refactor' into SKARA-1146-fixed-in-build
> - Rename variable
> - Remove unwanted change
> - Require branch fixVersion and backport fixVersion to match to update resolved in build
> - Refactor out common functionality
> - SKARA-1146
Marked as reviewed by kcr (Reviewer).
-------------
PR: https://git.openjdk.java.net/skara/pull/1271
More information about the skara-dev
mailing list