RFR: 1308: CSRBot only reacts to approved CSR if PR is touched

[Kevin Rushforth]

On Thu, 13 Jan 2022 21:15:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When a CSR issue is approved, any associated PR is only updated once someone touches the PR. The CSRBot will not evaluate anything about a PR unless there is a change to the PR. Since a CSR issue update only happens in JBS, the CSRBot cannot be limited by PR updates, it needs to check Jira for changes.
> 
> This patch removes the use of the PullRequestUpdateCache to limit when the bot evaluates a PR. If this turns out to generate too much load on JBS, we will have to implement a limiter in some way, but I don't think it will be a big issue in practice.

Looks good. I left one comment about a possible alternative, but it might not be worth doing.

bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 75:

> 73:             if (!cache.needsUpdate(pr)) {
> 74:                 continue;
> 75:             }

An alternative to eliminating this check would be to poll JBS either if the PR was updated or if the PR has a csr label. But as you say, maybe it won't be a performance problem, in which case your proposed change is better.

-------------

Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1274