Email collation of PR comments

erik.joelsson at oracle.com erik.joelsson at oracle.com
Tue Jan 18 14:16:00 UTC 2022


Hello David,

Nothing has changed in this area since I've been involved in the project 
(that I know of). I have also noticed that my comments aren't always 
included in the order I would have preferred, but I haven't looked 
further into it. Feel free to file a bug about it.

/Erik

On 2022-01-17 23:20, David Holmes wrote:
> Not sure if something was recently changed but I'm now noticing some 
> emails from PR's are collating comments in a way that makes the email 
> very awkward to read/understand.
>
> For example in:
>
> https://github.com/openjdk/jdk/pull/7079
>
> I made two comments (one stand-alone and one as part of approving the 
> change):
>
> ------------
> dholmes-ora commented 11 minutes ago
>
> Thanks Thomas! I was too focused on the original string and didn't 
> check that the exception code was going to make a copy anyway. There's 
> likely multiple copies made on the way to the final String object.
>
> dholmes-ora approved these changes 10 minutes ago
>
> dholmes-ora left a comment
>
> Seems fine.
>
> Thanks,
> David
> ------------
>
> but the email that was sent flipped the order and just ran them 
> together, so the email has:
>
> ------------
> Seems fine.
>
> Thanks,
> David
>
> Thanks Thomas! I was too focused on the original string and didn't 
> check that the exception code was going to make a copy anyway. There's 
> likely multiple copies made on the way to the final String object.
>
> -------------
>
>
> I would have expected the comments to be presented in the order in 
> which they were written, and that there would be some kind of 
> delimiter between them so you could tell they were distinct comments.
>
> Cheers,
> David


More information about the skara-dev mailing list