[External] : RE: Openjdk bot repo write access missing for backport branches

[erik.joelsson at oracle.com]

Hello Thomas,

On 2022-01-24 06:12, Thomas Stüfe wrote:
> Hi Erik,
>
> (removing updates-dev)
>
> thanks for looking at this.
>
> This morning I tried to backport this patch: 
> https://github.com/openjdk/jdk/commit/110e38ded8e09361f24c582c770d35f5cfdabf82 
> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/110e38ded8e09361f24c582c770d35f5cfdabf82__;!!ACWV5N9M2RV99hQ!dnHRr9kZiKjCM7xBuPWaMjuIZuwXCfLZtKTme8KwBbKJyfDSd5pTItT9oaCM_nvBo_A$> 
> to jdk17u-dev.
>
> Since I needed to change the patch before creating the PR, I followed 
> the instructions printed by the bot under "If you need to update the 
> source branch 
> <https://urldefense.com/v3/__https://github.com/openjdk-bots/jdk17u-dev/tree/tstuefe-backport-110e38de__;!!ACWV5N9M2RV99hQ!dnHRr9kZiKjCM7xBuPWaMjuIZuwXCfLZtKTme8KwBbKJyfDSd5pTItT9oaCMB0bPz5I$> ..." 
> but found that I could not push my changes back to the OpenJDK bot 
> repo. This morning, I did not get an invite mail when issuing the 
> /backport command. However, ten days ago I created my first /backport 
> for jdk17u-dev, and I got an invite mail then. But I had ignored that 
> invite since the patch applied cleanly and no change was needed. And 
> now that first invite is expired.
>
> Does the bot send an invite each time or only the first time I issue 
> /backport on a given repo?
>
I'm not sure how Github handles "invites", but the bot will try to add 
you with write permissions through the github API unless you already 
have write permission. Looking at the repo, you weren't in the 
collaborators, probably because the invite had timed out. My best guess 
is that the invite was still active when you created the last backport, 
so the bot didn't add you again, then it timed out soon after.

I have manually added you to this repo again.

/Erik

> Thanks, Thomas
>
>
>
>
> On Mon, Jan 24, 2022 at 2:46 PM <erik.joelsson at oracle.com> wrote:
>
>     Hello Thomas,
>
>     Permissions to the OpenJDK bot repos we use for backport PRs/branches
>     are handed out dynamically when you create a /backport. No bulk
>     invites
>     have been sent out AFAIK.
>
>     /Erik
>
>     On 2022-01-23 23:53, Langer, Christoph wrote:
>     > Hi,
>     >
>     > forwarding to skara-dev, cc Kevin/Erik to help you with that
>     one. They'll probably have to do this.
>     >
>     > Cheers
>     > Christoph
>     >
>     >> -----Original Message-----
>     >> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
>     >> Behalf Of Thomas Stüfe
>     >> Sent: Montag, 24. Januar 2022 07:17
>     >> To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
>     >> Subject: Openjdk bot repo write access missing for backport
>     branches
>     >>
>     >> Hi,
>     >>
>     >> I miss write access to backport PR branches created by the
>     OpenJDK bot. I
>     >> assume I missed the original invite mails? I found them, but
>     they are expired.
>     >>
>     >> This only matters if I need to adapt a PR branch created by the
>     OpenJDK bot
>     >> on my behalf (so it applied cleanly but needs changing), which
>     does not
>     >> happen often. Therefore I did not notice the missing access
>     until now.
>     >>
>     >> Is there a way to trigger the resending of invites for
>     openjdk-bots/jdk17u-
>     >> dev and openjdk-bots/jdk11u-dev?
>     >>
>     >> Thanks, Thomas
>