RFR: 1495: /backport on PRs instead of commits should inform of proper usage [v2]

Magnus Ihse Bursie ihse at openjdk.org
Sat Jul 9 17:08:32 UTC 2022

On Sat, 9 Jul 2022 16:29:24 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch mainly solves the issue described at SKARA-1495 which makes the `backport` command be valid in a pull request which has been integrated.
>> But in detail, this patch has the following feature or solves the following issues:
>> - Currently, the commands of the pull request and the commands of the commit are not related and can't be known from each other. So when we use the commit commands, such as `tag`, in the pull request, the bot replies `Unknown command tag`. Actually, the bot should replies the message like `The command tag can not be used in pull requests.  Please try to use this command on the commit`. The change is mainly at method `CommandExtractor::extractCommands`.
>> - Many places of the code use a duplicated method, named `resultingCommitHash`, this method could be put into class `PullRequest` to avoid the duplication. I refactor it in this patch.
>> - Now the `backport` command can not be used in pull requests. I revise the logic to let it available in a pull request which has been integrated, mainly removing the overrided method `allowedInPullRequest` of the class `BackportCommand`.
>> - The reason that these issues are not found before is that we hadn't tested all the branches of the code, especially the branches in methods `PullRequestCommandWorkItem::processCommand` and `CommitCommandWorkItem::processCommand`. So I add more test cases to test almost all the branches. And if the branch can't be tested, I add a comment to explain it.
>> Although it seems that many features are not related to SKARA-1495, I put them together as an enhance of the PullRequestBot.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Fix NPE.

Thank you for tackling this PR. Both Erik and I are on vacation right now, and you'll have to wait to get a full review.

My main worry here is that there were some underlying reason for not going this route with `/backport` on the PRs directly, that is not obvious to me, and that may make this change unsuitable.


PR: https://git.openjdk.org/skara/pull/1341

More information about the skara-dev mailing list