RFR: 1495: /backport on PRs instead of commits should inform of proper usage [v2]

Guoxiong Li gli at openjdk.org
Thu Jul 28 13:18:15 UTC 2022

On Thu, 28 Jul 2022 13:04:32 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 58:
>>> 56:     public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath,
>>> 57:                 CommandInvocation command, List<Comment> allComments, PrintWriter reply) {
>>> 58:         reply.println("The command `backport` can not be used in a pull request that has not yet been integrated.");
>> Shouldn't the message here be the one suggested in the Bug?
>> "(!) You cannot issue `/backport` on a pull request. Instead, give that command on the actual commit you want to backport."
> I want the`/backport` command can be used in the PRs which hava been integrated. So the message `You cannot issue /backport on a pull request` seems not accurate. But the current message seems not accurate too. Looking for a better description and your idea.

Additional information: When the PR has been integrated and the `backport` command is used in this integrated PR, the another `handle` method  instead of this method will be invoked so that the `backport` command can be processed.


PR: https://git.openjdk.org/skara/pull/1341

More information about the skara-dev mailing list