RFR: 1495: /backport on PRs instead of commits should inform of proper usage [v2]

Erik Joelsson erikj at openjdk.org
Thu Jul 28 20:45:55 UTC 2022

On Thu, 28 Jul 2022 20:16:10 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> But BackportCommand doesn't yet support running on a PR. That's still a feature that would need to be implemented.
> In this patch, it can be used at PRs which had been integrated. This is a main feature of this patch.

Oh, I see now that PullRequestCommandWorkItem will call the handle method for commit if the PR has been integrated. That was rather surprising behavior. In that case, please align the reply with the one in PullRequestCommandWorkItem:

printer.print("The command `");
printer.println("` can only be used in a pull request that has been integrated.");

Also, if that's the case, please change the bug and PR title to make this clear. That's the main feature being added here.


PR: https://git.openjdk.org/skara/pull/1341

More information about the skara-dev mailing list