RFR: 1434: Testissue#addLink doesn't generate the right relationship for the reversed link

Guoxiong Li gli at openjdk.java.net
Wed Jun 1 08:21:30 UTC 2022


On Tue, 31 May 2022 17:23:07 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch fixes the reversed link type. For example, when adding a `csr for` link at `ISSUE-1` which links to `ISSUE-2`, the `ISSUE-2` should have a reversed link `csr of` instead of the same link type `csr for`.
>> 
>> The reversed relations are shown below:
>> - `backported by` and `backport of`
>> - `csr for` and `csr of`
>> - `blocks` and `is blocked by`
>> - `clones` and `is cloned by`
>> 
>> And the `duplicates` link type doesn't have the reversed linke type like `duplicated by` now. So we should use the link type `duplicates` instead of `duplicated by` in the test cases so that the tests can be closer to the actual situation.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Marked as reviewed by erikj (Lead).

@erikj79 Thanks for the review.

-------------

PR: https://git.openjdk.java.net/skara/pull/1325


More information about the skara-dev mailing list