RFR: SKARA-1119: A bot should remind a PR author not to force push [v2]

Guoxiong Li gli at openjdk.java.net
Wed Jun 1 08:30:22 UTC 2022

On Tue, 31 May 2022 18:16:13 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Fix suggestion comment.
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 39:
>> 37:             Please don't rebase and force-push to your branch of this PR because it invalidates previous review comments. \
>> 38:             To keep track of your changes incrementally, you only need to merge the target branch (optionally), \
>> 39:             commit your new change and push normally. The bot can squash them as a single commit when integrating.
> Suggestion:
>             Please do not rebase or force-push to an active PR as it invalidates existing review comments. \
>             All changes will be squashed into a single commit automatically when integrating. \
>             See [OpenJDK Developers’ Guide](https://openjdk.java.net/guide/#working-with-pull-requests).



PR: https://git.openjdk.java.net/skara/pull/1328

More information about the skara-dev mailing list