RFR: 1410: The reply message of the 'reviewers' command should be more accurate [v2]
Guoxiong Li
gli at openjdk.java.net
Wed Jun 1 08:34:39 UTC 2022
On Tue, 31 May 2022 17:28:43 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix comment.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 123:
>
>> 121: if (previous.isPresent()) {
>> 122: if (roleIsLower(role, previous.get().role())) {
>> 123: reply.println("Only the [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to lower the role for additional reviewers.");
>
> Suggestion:
>
> reply.println("Only [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to lower the role for additional reviewers.");
Fixed
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 127:
>
>> 125: }
>> 126: if (numReviewers < previous.get().number()) {
>> 127: reply.println("Only the [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to decrease the number of required reviewers.");
>
> Suggestion:
>
> reply.println("Only [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to decrease the number of required reviewers.");
Fixed
-------------
PR: https://git.openjdk.java.net/skara/pull/1326
More information about the skara-dev
mailing list