RFR: 1433: The change of the CSR status doesn't force the CheckWorkItem to re-run the check [v2]

Guoxiong Li gli at openjdk.java.net
Mon Jun 6 08:26:19 UTC 2022


On Mon, 6 Jun 2022 08:10:14 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>>> (optionally) use command /csr needed again
>>> (optionally) then the CheckWorkItem also doesn't re-run the check
>> 
>> Sometimes the developers may use the `/csr` command again. I would like to let the CheckWorkItem re-run the check immediately instead of waiting for JEPBot, which may reduce about 10 minutes.
>
> I don't understand what you mean. You set these markers, but I don't see anything looking for them.

// file CheckWorkItem.java
-    private final Pattern metadataComments = Pattern.compile("<!-- (?:(add|remove) (?:contributor|reviewer))|(?:summary: ')|(?:solves: ')|(?:additional required reviewers)|(?:jep: ')");
+    private final Pattern metadataComments = Pattern.compile("<!-- (?:(add|remove) (?:contributor|reviewer))|(?:summary: ')|(?:solves: ')|(?:additional required reviewers)|(?:jep: ')|(?:csr: ')");


The newly added `(?:csr: ')` can search it and update the metadata so that the check can be re-run.

-------------

PR: https://git.openjdk.java.net/skara/pull/1327


More information about the skara-dev mailing list