RFR: 1432: The command `/csr unneeded` doesn't correctly handle an approved CSR
Guoxiong Li
gli at openjdk.java.net
Tue Jun 7 11:30:37 UTC 2022
Hi all,
Currently, when using the command `/csr unneeded` and the PR doesn't have `csr` label, the `CSRCommand` can't distinguish the situations of having no csr request and having an approved csr request. This patch removes the conditional statement `labels.contains(CSR_LABEL)` of the method `CSRCommand::handle` so that its following code can distinguish the different situations and reply different messages.
And the code about removing `csr` label is moved to the method `csrUnneededReply` to reduce some duplication.
Thanks for taking the time to review.
Best Regards,
-- Guoxiong
-------------
Commit messages:
- SKARA-1432
Changes: https://git.openjdk.java.net/skara/pull/1331/files
Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1331&range=00
Issue: https://bugs.openjdk.org/browse/SKARA-1432
Stats: 29 lines in 2 files changed: 10 ins; 11 del; 8 mod
Patch: https://git.openjdk.java.net/skara/pull/1331.diff
Fetch: git fetch https://git.openjdk.java.net/skara pull/1331/head:pull/1331
PR: https://git.openjdk.java.net/skara/pull/1331
More information about the skara-dev
mailing list