RFR: 1432: The command `/csr unneeded` doesn't correctly handle an approved CSR

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Jun 7 11:57:57 UTC 2022

On Tue, 7 Jun 2022 11:26:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> Currently, when using the command `/csr unneeded` and the PR doesn't have `csr` label, the `CSRCommand` can't distinguish the situations of having no csr request and having an approved csr request. This patch removes the conditional statement `labels.contains(CSR_LABEL)` of the method `CSRCommand::handle` so that its following code can distinguish the different situations and reply different messages.
> And the code about removing `csr` label is moved to the method `csrUnneededReply` to reduce some duplication.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

Looks good to me.


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1331

More information about the skara-dev mailing list