RFR: 1475: Support separate 8u releases identified with an opt string

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Jun 14 16:46:09 UTC 2022

On Mon, 13 Jun 2022 15:26:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch adds a configuration option for the IssueNotifier. This new option controls how tags are matched with fixVersion when updating the Resolved In Build field. Currently, any "opt" string in the fixVersion (e.g. 17.0.4-oracle) is ignored as tags are do not include the 'oracle' opt string. We now have the need to require tags to include such a string for some releases/versions. I believe this should be the default behavior and ignoring "oracle" should be the exception.
> The new option goes into the issue part of the notifier block. By default, the opt string will be considered part of the version string and required in the tag for a match (this is the opposite of the current behavior). By using the new option, a set of opt strings that should not be required in a tag for a match may be configured. In the example below a tag `jdk8u341-b01` would match a fix version of `8u341-foo`.
> "issue": {
>   "tag": {
>     "ignoreopt": [ "foo", "bar" ],
>   }
> }

It looks good to me, but my understanding about the entire fixVersion thingie is admittedly a bit hand-wavy. I think it would be good if @kevinrushforth could have a look at it as well.


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1335

More information about the skara-dev mailing list