RFR: 1480: Update all openjdk.java.net->openjdk.org

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Jun 14 18:51:51 UTC 2022

On Tue, 14 Jun 2022 17:44:45 GMT, Raffaello Giulietti <duke at openjdk.org> wrote:

>> The Skara source tree contains a lot of references to openjdk.java.net. All of them need to be updated to the new URL openjdk.org. Some of these are essential for core functionality such as jcheck so this is quite urgent.
>> This patch is a simple search-replace.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelCommand.java line 39:
>> 37:     private static final Pattern argumentPattern = Pattern.compile("(?:(add|remove)\\s+)((?:[A-Za-z0-9_ at .-]+[\\s,]*)+)");
>> 38:     private static final Pattern shortArgumentPattern = Pattern.compile("((?:[-+]?[A-Za-z0-9_ at .-]+[\\s,]*)+)");
>> 39:     private static final Pattern ignoredSuffixes = Pattern.compile("^(.*)(?:-dev(?:@openjdk.org)?)$");
> The literal dot in `openjdk.org` inside the `Pattern` should probably be escaped
> `private static final Pattern ignoredSuffixes = Pattern.compile("^(.*)(?:-dev(?:@openjdk\.org)?)$");`
> I didn't check if there are other occurrences, though.

While you are technically correct, this was not done before either. I don't think we should combine a massive, but trivial, search-and-replace PR with additional hands-on-fixes like that.


PR: https://git.openjdk.org/skara/pull/1338

More information about the skara-dev mailing list