RFR: 1482: Add more metrics

Erik Helin ehelin at openjdk.org
Thu Jun 16 13:20:27 UTC 2022


On Thu, 16 Jun 2022 12:47:34 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> In order to better analyze Skara bot performance, I need more metrics. Specifically the skara_runner_*_time gauges are pretty useless in their current form. They would be more useful as counters so we could look at the total execution time for workitems for a specific bot instead of randomly picked single executions of the same.

Looks good, Reviewed.

I don't really recall why I went with `Gauge` here in the first place, I should probably just have used `Counter` from the beginning. Seeing this patch I would have opted for dropping the gauges, but feel free to them in for a while to see if you need them.

Thanks,
Erik

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.org/skara/pull/1339


More information about the skara-dev mailing list