RFR: 1419: The Skara PR bot should not block on a JEP if not enabled for a repo

Erik Joelsson erikj at openjdk.java.net
Tue May 3 12:54:56 UTC 2022

On Tue, 3 May 2022 00:22:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> If a repository doesn't support JEP and someone issues the `/jep` command in the PR of this repo, the bot should replies a comment instead of blocking the PR. This patch adds a jep config to the PR bot and adjusts the test cases.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 83:

> 81:                        List<Comment> allComments, PrintWriter reply, List<String> labelsToAdd, List<String> labelsToRemove) {
> 82:         if (!bot.enableJep()) {
> 83:             reply.println("this repository is not allowed to use the `jep` command.");


            reply.println("This repository has not been configured to use the `jep` command.");


PR: https://git.openjdk.java.net/skara/pull/1310

More information about the skara-dev mailing list