RFR: 1419: The Skara PR bot should not block on a JEP if not enabled for a repo [v2]

Guoxiong Li gli at openjdk.java.net
Tue May 3 13:40:10 UTC 2022


On Tue, 3 May 2022 13:03:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 83:
>> 
>>> 81:                        List<Comment> allComments, PrintWriter reply, List<String> labelsToAdd, List<String> labelsToRemove) {
>>> 82:         if (!bot.enableJep()) {
>>> 83:             reply.println("this repository is not allowed to use the `jep` command.");
>> 
>> Suggestion:
>> 
>>             reply.println("This repository has not been configured to use the `jep` command.");
>
> Does the csr command also use the `has not been configured`?

Fixed. And the csr command is also adjusted.

-------------

PR: https://git.openjdk.java.net/skara/pull/1310


More information about the skara-dev mailing list