RFR: 1385: Backport MR links to the wrong CSR request

David Holmes dholmes at openjdk.java.net
Sun May 8 22:18:54 UTC 2022

On Sun, 8 May 2022 13:19:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> This patch solves the wrong CSR in the backport PR. It mainly has the following rules:
> 1. if the `version` in `.jcheck/conf` doesn't exist or the `version` is wrong, the bot think the CSR also doesn't exist.
> 2. else, if the `version` in `.jcheck/conf` matches the fix version of the primary CSR, the bot will use the primary CSR. (primary CSR is the CSR of the primary issue)
> 3. else, if these is a backport issue matches the `version`, the bot will find the CSR of the backport issue. If found, use it. If not, the bot think the CSR doesn't exist.
> 4. else (no backport issue matches the `version`) the bot think the CSR doesn't exist.
> The classes `CSRBot`, `CheckRun` and `CSRCommand` will handle the situations above respectively.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong


There may be another case not covered by my reading of the above rules.

Consider this situation:
- there is a primary issue for release 17 and a corresponding CSR
- there is a backport for release 11 and a corresponding CSR that is marked for multiple versions: 8-pool, 11-pool, 13-pool, 15-pool
- A PR is created for a backport to 8u

The search for a CSR matching the current 8u backport, has to search all of the existing backports for such a CSR request.


PR: https://git.openjdk.java.net/skara/pull/1318

More information about the skara-dev mailing list