RFR: 1385: Backport MR links to the wrong CSR request [v3]
Guoxiong Li
gli at openjdk.java.net
Tue May 10 14:18:20 UTC 2022
> Hi all,
>
> This patch solves the wrong CSR in the backport PR. It mainly has the following rules:
> 1. if the `version` in `.jcheck/conf` doesn't exist or the `version` is wrong, the bot think the CSR also doesn't exist.
> 2. else, if the `version` in `.jcheck/conf` matches the fix version of the primary CSR, the bot will use the primary CSR. (primary CSR is the CSR of the primary issue)
> 3. else, if these is a backport issue matches the `version`, the bot will find the CSR of the backport issue. If found, use it. If not, the bot think the CSR doesn't exist.
> 4. else (no backport issue matches the `version`) the bot think the CSR doesn't exist.
>
> The classes `CSRBot`, `CheckRun` and `CSRCommand` will handle the situations above respectively.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
Refactor code. Search CSR uniformly. Fix message.
-------------
Changes:
- all: https://git.openjdk.java.net/skara/pull/1318/files
- new: https://git.openjdk.java.net/skara/pull/1318/files/1a7e4853..07d900ce
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=skara&pr=1318&range=02
- incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1318&range=01-02
Stats: 172 lines in 4 files changed: 37 ins; 106 del; 29 mod
Patch: https://git.openjdk.java.net/skara/pull/1318.diff
Fetch: git fetch https://git.openjdk.java.net/skara pull/1318/head:pull/1318
PR: https://git.openjdk.java.net/skara/pull/1318
More information about the skara-dev
mailing list